🧹 chore: baseline Java 17#708
Open
gaeljw wants to merge 2 commits into
Open
Conversation
gaeljw
commented
May 15, 2026
Closed
7 tasks
There was a problem hiding this comment.
Pull request overview
Updates Anorm’s build/tooling to require Java 17 and emit Java 17 classfiles, aligning the project with the newer baseline requested in #707.
Changes:
- Baseline compilation to Java 17 (
-release 17) and update CI/publish workflows to run on Java 17. - Simplify cross-building by dropping Scala 2.12-specific source layout/config (Scala 2.13 + 3 only).
- Remove the legacy
anorm-iterateemodule and its manual documentation section; consolidate cross-version compat helpers.
Reviewed changes
Copilot reviewed 9 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
project/Common.scala |
Switch default/cross Scala versions and compile target to Java 17; remove Scala 2.12-specific unmanaged source directory logic. |
build.sbt |
Pin H2 test dependency; remove anorm-iteratee project; simplify Akka/Pekko settings now that Scala 2.12 is gone; update docs project deps. |
core/src/main/scala/anorm/Compat.scala |
Consolidate compatibility helpers into the main source set (no longer split by Scala version directory). |
core/src/main/scala-2.13-/Compat.scala |
Remove old Scala-version-specific Compat implementation. |
akka/src/test/scala/anorm/AkkaCompat.scala |
Add unified Akka test compat alias. |
akka/src/test/scala-2.13-/AkkaCompat.scala |
Remove old Scala-version-specific Akka compat file. |
pekko/src/test/scala/anorm/PekkoCompat.scala |
Add unified Pekko test compat alias. |
pekko/src/test/scala-2.13-/PekkoCompat.scala |
Remove old Scala-version-specific Pekko compat file. |
iteratee/src/main/scala/anorm/Iteratees.scala |
Remove iteratee streaming integration implementation. |
iteratee/src/test/scala/anorm/IterateeSpec.scala |
Remove iteratee module tests. |
docs/manual/working/scalaGuide/main/sql/ScalaAnorm.md |
Remove iteratee module section from the manual. |
.github/workflows/publish.yml |
Publish workflow now uses Java 17. |
.github/workflows/build-test.yml |
Collapse CI matrix to Java 17 and remove Java 8/11 jobs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Fixes
Solves #707 ; built on top of #709 (read only the 2nd commit)
Purpose
Generate Java 17 class files. Upgrade the minimum required Java version to 17 for users.